Skip to content

[BI-2555] - Fix Germplasm By List Default Sorting#431

Merged
mlm483 merged 4 commits intodevelopfrom
bug/BI-2555
Mar 26, 2025
Merged

[BI-2555] - Fix Germplasm By List Default Sorting#431
mlm483 merged 4 commits intodevelopfrom
bug/BI-2555

Conversation

@mlm483
Copy link
Contributor

@mlm483 mlm483 commented Mar 14, 2025

Description

Story: https://breedinginsight.atlassian.net/browse/BI-2555

The GermplasmTable component is used by both AllGermplasm and GermplasmByList. Because AllGermplasm and GermplasmByList have different default sort requirements, and should both remember the user-selected sort when the user navigates away and back again, they needed to be updated to use different pieces of Vuex state. I moved the sorting state management up to the parent components, and added props for germplasmSort and updateGermplasmSort to GermplasmTable.

Dependencies

None

Testing

  • Upload germplasm to a program.
  • Ensure the default sort of the all germplasm table is GID, descending.
  • Ensure the default sort of the germplasm by list table is import entry number, ascending.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>
  • I have run SiteImprove on pages impacted by changes

@github-actions github-actions bot added the bug Something isn't working label Mar 14, 2025
@mlm483 mlm483 marked this pull request as ready for review March 21, 2025 14:47
@mlm483 mlm483 requested review from a team, HMS17 and davedrp and removed request for a team March 21, 2025 14:47
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed. Code looks good.

@mlm483 mlm483 merged commit 58ea2ca into develop Mar 26, 2025
1 check passed
@mlm483 mlm483 deleted the bug/BI-2555 branch March 26, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants